Incorrect sequence of calling callbacks on_take & on_put on swapping items in inventory

[alek13]

Minetest version

5.7.0

OS / Hardware

Operating system: Kubuntu 22.04.2 LTS

Summary

When swapping items in inventory, MT calls:

• at first on_put
• and then on_take

It will be better if MT calls it in reverse order:

• on_take
• on_put

Steps to reproduce

For example, with LOTT game:

1. Install LOTT
2. • also you can add debug prints into log here
3. Open inventory, creative tab, search&take "Mithril boots" and "Training boots"
4. Open Main tab and put on Mithril one
5. Take wooden Training one and swap it with Mithril

As result:

• you have no boots on preview in inventory
• you have no boots on player model (F7)
• and also you have no protection
  

[SmallJoker]

PR already exists but waits on another PR which waits for its author #12595