Fix max_formspec_size not taking gui_scaling into account #13493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
reviewed
May 21, 2023
Zughy
added
the
Action / change needed
rubenwardy
reviewed
May 22, 2023
rubenwardy
removed
the
Action / change needed
SmallJoker
approved these changes
Jun 10, 2023
grorp
changed the title
grorp
changed the title
Desour
reviewed
Jun 19, 2023
Desour
approved these changes
Jun 19, 2023
|
Hi, please wait for me to test this |
SmallJoker
added
the
Waiting (on dependency)
rubenwardy
added
@ Client / Audiovisuals
Formspec
and removed
Waiting (on dependency)
|
Bump. This has now also been approved by rubenwardy, so I think it should be ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
max_formspec_sizevalue returned byminetest.get_player_window_information()is currently incorrect if the player has set thegui_scalingsetting to a value other than 1.That's because
prefer_imgsizeinGUIFormSpecMenu::regenerateGui(link to the code) is scaled bygui_scaling, butClientDynamicInfo::calculateMaxFSSize(link to the code) doesn't care. This PR just adds a division bygui_scalingtocalculateMaxFSSize.This bug cannot be worked around by mods since mods don't get the
gui_scaling, but only thereal_gui_scaling(gui_scaling* display density) of the player. Therefore, fixing this bug cannot not break any mods that already work around it.To do
This PR is a Ready for Review.
How to test
Set
gui_scalingto 0.5.On the master branch, start Devtest and do
/testfullscreenfs. The formspec won't be shown fullscreen.Do the same on this PR. The formspec will be shown fullscreen.