ContentDB GUI: Load package list asynchronously #13551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grorp
force-pushed
the
async-fetch-packages
branch
from
c0c5e59
to
6d8d90f
Compare
grorp
commented
Jun 2, 2023
|
Here are two screenshots to show the changes I made to the GUI: before: after: Notice that the German translations are less truncated and that there's some space between the scrollbar of the "Bonemeal" package and its delete button. The dialog is still slightly offset to the bottom on desktop, that offset has only been removed on Android. |
The text filter and the current page are reset too. I wonder why the type filter was left out.
grorp
force-pushed
the
async-fetch-packages
branch
from
4697098
to
da52b43
Compare
rubenwardy
approved these changes
Jul 30, 2023
| @@ -735,7 +762,30 @@ function store.filter_packages(query) | |||
| end | |||
| end | |||
|
|
|||
| local function get_info_formspec(offset, text) | |||
There was a problem hiding this comment.
Maybe alert would be a better name than info - info could refer to package info. But I don't mind
SmallJoker
approved these changes
Aug 13, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP request for loading the ContentDB package list is currently done synchronously. This results in a poor user experience and, on Android, sometimes ANRs.
With this PR, the HTTP request is done asynchronously and a "Loading..." dialog is shown in the meanwhile. While I was at it, I also made some small improvements to the ContentDB formspec: I increased the size of some buttons to give translations more space to breathe, and I added a back button to the "No packages could be retrieved" dialog. (Fun fact: The dialog actually already had one, but it was outside the visible area of the formspec in all possible scenarios.)
This is probably best reviewed with whitespace changes hidden.
To do
This PR is a Ready for Review.
How to test
Go to "Content" -> "Browse online content" and enjoy the loading screen and the package list. Verify that an error message is shown if you have no internet connection. Also verify that the loading screen is not shown anymore once the package list has been successfully loaded once.