Auto-detect locale on Android #13561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused putMessageBoxResult function - Rename unused javaStringToUTF8 function to readJavaString and use it where possible - Improve the error messages
srifqi
requested changes
Jun 4, 2023
android/app/src/main/java/net/minetest/minetest/GameActivity.java
Outdated
Show resolved
Hide resolved
Zughy
added
the
Action / change needed
Co-authored-by: Gregor Parzefall <gregor.parzefall@posteo.de>
srifqi
approved these changes
Jun 4, 2023
srifqi
added
One approval ✅ ◻️
and removed
Action / change needed
sfan5
reviewed
Jun 4, 2023
android/app/src/main/java/net/minetest/minetest/GameActivity.java
Outdated
Show resolved
Hide resolved
|
Minetest formspec can cutoff many translations, but this may help people who dont know English |
rubenwardy
approved these changes
Jun 5, 2023
arihant2math
pushed a commit
to arihant2math/minetest
that referenced
this pull request
Jun 11, 2023
Wuzzy2
pushed a commit
to Wuzzy2/minetest
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Minetest for Android use the system language if the user hasn't set a custom language in the Minetest settings. I also did some code cleanup.
Related PR: #11435
To do
This PR is a Ready for Review.
How to test
Open Minetest for Android on your phone, verify that it uses your system language if you haven't set a custom language in the Minetest settings.