Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion] Define a policy for raising our dependencies' versions #13583

Closed
Desour opened this issue Jun 11, 2023 · 2 comments
Closed

[discussion] Define a policy for raising our dependencies' versions #13583

Desour opened this issue Jun 11, 2023 · 2 comments
Assignees
Labels
Discussion Issues meant for discussion of one or more proposals @ Documentation Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements

Comments

@Desour
Copy link
Member

Desour commented Jun 11, 2023

I'd like to be able to use C++17, and also C++20 when available, to have an easier life. And upgrading other libs and tools (like cmake) is also nice to have.

Our dependencies are listed here:
https://github.com/minetest/minetest/blob/master/doc/compiling/linux.md#dependencies
But it's nowhere defined based on what they are limited, or in other words, which distributions we want to support. This makes it unclear at what point we may raise the dependency versions.

Just an example how such a policy can look like:
https://opensource.google/documentation/policies/cplusplus-support

Suggestion for a policy:
Always support all ubuntu lts version that still have full ubuntu support.
Rationale: Ubuntu is rather conservative, so few people of other distros will see breakage.

Also relevant: The end of support for ubuntu 18.04 is/was this year, and github isn't even providing a runner for it anymore, so we're currently skipping our old gcc and clang ci builds (we could still use docker for older versions though):
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
https://ubuntu.com/about/release-cycle
7bfea9b

Edit: See also https://irc.minetest.net/minetest-dev/2023-06-11#i_6090527.

@Desour Desour added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Discussion Issues meant for discussion of one or more proposals labels Jun 11, 2023
@Zughy
Copy link
Member

Zughy commented Oct 7, 2023

Just in case you missed it and you want to proceed with such proposal, you've received 2 thumbs up by 2 different core devs

@Desour
Copy link
Member Author

Desour commented Oct 8, 2023

I've seen that. I'm working on a draft. I just haven't finished it yet because doing this stuff is kinda boring, and there's no need to hurry.

@Desour Desour self-assigned this Jan 21, 2024
@sfan5 sfan5 closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issues meant for discussion of one or more proposals @ Documentation Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements
Projects
None yet
Development

No branches or pull requests

3 participants