[NOSQUASH] Remove trigonometry from liquid drawing #13599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
reviewed
Jun 17, 2023
Desour
reviewed
Jun 19, 2023
numberZero
force-pushed
the
no-trig-in-liquids
branch
from
3b05fc4
to
50de9b6
Compare
SmallJoker
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13217
Replaces
atan2+rotateBycombo with matrix multiplication (inlined, since Irrlicht lacks 2×2 matrix type apparently).Also, some cleanup in nearby code to ensure exact values are exact (avoiding
*BS/BS).To do
This PR is Ready for Review.
How to test
Look at flowing liquid. Compare with current master. Pay attention to symmetrical cases (e.g. a flowing liquid node surrounded with sources at all 4 sides).