Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOSQUASH] Cleanup tile rotation #13600

Merged
merged 4 commits into from Jun 22, 2023
Merged

[NOSQUASH] Cleanup tile rotation #13600

merged 4 commits into from Jun 22, 2023

Conversation

numberZero
Copy link
Contributor

To do

This PR is Ready for Review.

How to test

Test facedir nodes.
I guess this should be unit-testable but there aren’t any tests yet.

sfan5
sfan5 approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as far as I can see

SmallJoker
SmallJoker approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this how it should be tested? If so: works 👍

out

@sfan5 sfan5 merged commit 7c26cb1 into minetest:master Jun 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
@ Client rendering Performance >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Optimize trigonometry out of MapblockMeshGenerator::drawCuboid
4 participants
@numberZero @sfan5 @SmallJoker @wsor4035