Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveObjectMgr::getActiveSelectableObjects #13615

Merged
merged 3 commits into from Jun 29, 2023
Merged

ActiveObjectMgr::getActiveSelectableObjects #13615

merged 3 commits into from Jun 29, 2023

Conversation

numberZero
Copy link
Contributor

@numberZero numberZero commented Jun 20, 2023 •
edited

Add compact, short information about your PR for easier understanding:

  • Goal of the PR:
    Simplify math
  • How does the PR work?
    shootline drawio
  • Does it resolve any reported issue?
    No.
  • Does this relate to a goal in the roadmap?
  • If not a bug fix, why is this PR needed? What usecases does it solve?

To do

This PR is a Work in Progress.

  • Add unit tests
  • Sort out commits
  • (maybe) Update docs

How to test

Check that object selection works as usual. Pay attention to rotating selection boxes.

@sfan5
Copy link
Member

sfan5 commented Jun 20, 2023

Can we get some basic unittests for this?

@Desour
Copy link
Member

Desour commented Jun 20, 2023

So you're essentially replacing the cuboid with a cylinder, right? Looks fine.

@Zughy Zughy added the Roadmap The change matches an item on the current roadmap. label Jun 20, 2023
@numberZero numberZero marked this pull request as ready for review June 24, 2023 17:17
@numberZero
Copy link
Contributor Author

Can we get some basic unittests for this?

Done

So you're essentially replacing the cuboid with a cylinder, right? Looks fine.

Yes

Is there a way to add a diagram to the docs?

sfan5
sfan5 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@sfan5
Copy link
Member

sfan5 commented Jun 26, 2023

Is there a way to add a diagram to the docs?

You can drop it into doc if you consider it important enough.

Desour
Desour approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@Desour Desour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Code looks fine.

@sfan5 sfan5 merged commit dde8f0e into minetest:master Jun 29, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

@Desour Desour Desour approved these changes

Assignees
No one assigned
Labels
Code quality Performance Roadmap The change matches an item on the current roadmap. >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@numberZero @sfan5 @Desour @wsor4035 @Zughy