guiScalingFilter: prevent infinite loop caused by negative background9[] size #13624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitlab.com/Df458/cartographer + https://gitlab.com/Df458/cartographer-mtg create a formspec where a
background9[]
element has a negative Y size. This results insh=-1.000
and invalid texture dimensions inimageScaleNNAA
which then locks up Minetest.This PR now skips invalid sized textures and outputs an error message in case it was not checked previously.
To do
This PR is Ready for Review.
How to test