Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace PP with operator overload #13630

Merged
merged 2 commits into from Jun 26, 2023
Merged

Replace PP with operator overload #13630

merged 2 commits into from Jun 26, 2023

Conversation

numberZero
Copy link
Contributor

@numberZero numberZero commented Jun 25, 2023 •
edited

  • Goal of the PR
    Code cleanness
  • How does the PR work?
    Replaces the PP and PP2 macros with overloaded << operators. The operator are in the irr::core namespace but are found with ADL.
  • Does it resolve any reported issue?
    No AFAIK
  • Does this relate to a goal in the roadmap?
    Yes, 2.2 “Internal code refactoring”
  • If not a bug fix, why is this PR needed? What usecases does it solve?

To do

This PR is Ready for Review.

How to test

@nerzhul
Copy link
Member

nerzhul commented Jun 25, 2023

clearly: yes !
why i didn't thought about this before ? :D

@Zughy Zughy added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Code quality labels Jun 25, 2023
@sfan5 sfan5 merged commit 3b74cc4 into minetest:master Jun 26, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerzhul nerzhul nerzhul approved these changes

Assignees
No one assigned
Labels
Code quality Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@numberZero @nerzhul @sfan5 @Zughy