Add unit tests for isBlockInSight() #13631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
added
the
Maintenance
SmallJoker
reviewed
Jun 25, 2023
SmallJoker
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Thank you for the changes. In the meantime I noticed that the map function does not actually shorten the code when compared to simple copying & iterating:
std::vector<v3s16> tmpdata = testdata1;
for (v3s16 &v : tmpdata)
v.rotateXZBy(j*90);
test1(tmpdata);Anyway, the expected return values do make sense and the code looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bug did not reveal itself but we have a test now
To do
This PR is Ready for Review.