Improve messages when changing viewing range and exceeding server-set limit #13647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine by me. :) Have been thinking recently that elsewhere we say "disabled by game or mod", for example when you want to zoom. That might be a better language than "disabled by server". |
Updated. |
|
@srifqi Cool. I wasn't 100% about the wording, seems wordy. Then again I created the original messages, which I do not like. :) |
|
The word server would only make sense when playing in a multi-player world. The phrase game or mod can be applied for both single- and multi-player world. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the "status text" messages that are shown when you increase or decrease the viewing range or toggle unlimited viewing range and exceed the server-set limit (set via
set_sky, see PR #13448).To do
This PR is a Ready for Review.
How to test
Set various
fog_distancevalues viaplayer:set_sky. Increase and decrease the viewing range and toggle unlimited viewing range. Verify that the messages always make sense, correctly reflect what has happened and are unambiguous.