Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string conversion for FreeBSD #13648

Merged
merged 2 commits into from Jul 17, 2023
Merged

Conversation

nekobbbbbbit
Copy link
Contributor

@nekobbbbbbit nekobbbbbbit commented Jul 7, 2023

Add compact, short information about your PR for easier understanding:

Fixes "<invalid UTF-8 string>" issue on FreeBSD.

I think it should work, dunno haven't tested it. But I'm certain it works.

Reproduce: Press F5 in game, look at coordinate information

Issue: https://forum.minetest.net/viewtopic.php?f=6&t=27100

@wsor4035 wsor4035 added Bugfix 🐛 PRs that fix a bug BSD labels Jul 7, 2023
@SmallJoker
Copy link
Member

Is _SYSTYPE_BSD defined on your side, by any chance? A general macro would also solve this issue for other BSD variants, if there is one in the first place.

@nekobbbbbbit
Copy link
Contributor Author

Is _SYSTYPE_BSD defined on your side, by any chance? A general macro would also solve this issue for other BSD variants, if there is one in the first place.

I think it's probably safer to keep them separate. May also play poorly with macOS

src/util/string.cpp Show resolved Hide resolved
@nekobbbbbbit
Copy link
Contributor Author

Not sure that's needed, but fixed

@sfan5 sfan5 added the Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines label Jul 9, 2023
@SmallJoker SmallJoker merged commit 50234b8 into minetest:master Jul 17, 2023
13 checks passed
Wuzzy2 pushed a commit to Wuzzy2/minetest that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSD Bugfix 🐛 PRs that fix a bug One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants