Fix that transparent text still draws a text shadow #13649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srifqi
approved these changes
Jul 16, 2023
Desour
reviewed
Jul 16, 2023
Wuzzy2
pushed a commit
to Wuzzy2/minetest
that referenced
this pull request
Jul 31, 2023
Makes fade out animations of text more pleasant to look at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, text shadows don't respect the alpha value of text. This is a problem for status text messages, which are faded out by changing their alpha value. This video shows the incorrect "out-fading" before this PR:
incorrect.fading.before.this.PR.2.mp4
Notice that the text fades to grey (the color of the text shadow) and then just disappears.
This PR changes the rendering of text shadows so that the alpha value of the text shadow is multiplied by the alpha value of the text itself. This results in correct "out-fading":
correct.fading.after.this.PR.2.mp4
(The second video is outdated, it was taken before bf1e6a3.)
Notice that the text fades out until it is fully transparent.
To do
This PR is a Ready for Review.
How to test
Trigger some status text messages. Verify that they fade out until they are fully transparent.