Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sound manager not being stepped by GUIEngine #13661

Merged
merged 1 commit into from Jul 14, 2023

Conversation

Desour
Copy link
Member

@Desour Desour commented Jul 13, 2023

Fixes #13660.

(The dtime calculation is not perfect here, i.e. we still always sleep for a fixed time. I'll leave that to another PR.)

In case you're worried that sounds are streamed too infrequently if the window is unfocused:

To do

This PR is a Ready for Review.

How to test

Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Desour Desour merged commit 8e09077 into minetest:master Jul 14, 2023
13 checks passed
@Desour Desour deleted the sound_engine_step branch July 14, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main menu music suddenly stops
2 participants