Fix sound manager not being stepped by GUIEngine #13661
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13660.
(The dtime calculation is not perfect here, i.e. we still always sleep for a fixed time. I'll leave that to another PR.)
In case you're worried that sounds are streamed too infrequently if the window is unfocused:
To do
This PR is a Ready for Review.
How to test
devtest/menu/theme.ogg
.Side note: Putting
menu_music.ogg
in one's sound pack doesn't work anymore since Allow for Game-Specific Menu Music #11241. :/