Persist menu textinput #13685
Merged
Persist menu textinput #13685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Montandalar
force-pushed
the
persist-menu-textinput
branch
2 times, most recently
from
43d82ed
to
0c16240
Compare
sfan5
reviewed
Jul 24, 2023
Zughy
added
Action / change needed
Previously, the username and port fields would be reset to their defaults when the formspec is re-sent. This persists any changes, without committing to the settings until the proper time.
Previously it was ignored if no bind address is configured due to an oversight.
Montandalar
force-pushed
the
persist-menu-textinput
branch
from
0c16240
to
27fd00d
Compare
|
Rephrased "resending" to "updating" and force pushed. Is squashing the two current commits going to be a problem or will that work fine despite the authorship variance? |
Zughy
removed
the
Action / change needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is purely a rebase and small fixup of #13612 . Credit to archfan7411 for the original commit. My fixups are (1) to move the new code block up as per SmallJoker's feedback and (2) a fix for when a bind address for the server is not configured, which was not working properly for the port field in the original PR.
Implementation note: The typed username persists so long as the main menu stays open, no matter what tab is visited, but isn't saved unless a server is launched or the setting is changed by some other means such as by joining a server or using the settings menu.
To do
This PR is Ready for Review.
How to test
Test 1
Test 2