TouchScreenGUI: Fix only 9 hotbar slots being usable #13698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zughy
added
Android
Bugfix 🐛
|
Thank you for this fix. I was not sure about the hotbar when refactoring |
srifqi
requested changes
Aug 2, 2023
|
The merge conflict is caused by the same TouchScreenGUI compilation error fix that this PR proposes because the fix has been merged separately (7f9de5d). |
srifqi
added
Rebase needed
grorp
force-pushed
the
touchscreengui-hotbar
branch
from
0768cba
to
8fc5f61
Compare
Co-authored-by: Muhammad Rifqi Priyo Susanto <muhammadrifqipriyosusanto@gmail.com>
Co-authored-by: Muhammad Rifqi Priyo Susanto <muhammadrifqipriyosusanto@gmail.com>
Zughy
removed
Rebase needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #13691.
Before this PR, TouchScreenGUI simply emitted a keypress event for one of the number keys when a hotbar item was pressed. After the 9th hotbar item (the last one for which there is a number key), it started pressing "random" keys.
After this PR, all hotbar items are selectable (except if they are hidden behind other controls, but that's a different issue).
To do
This PR is a Ready for Review.
How to test
Install the CI-built APK on your Android device. Start a Devtest world and execute
/hotbar 20. Verify that you can select all hotbar slots. Verify that you cannot use the 19th hotbar slot to change your camera mode.Because I rebased this PR, you'll experience #13743 while testing.