Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO SQUASH] async env / mapgen fixes #13703

Merged
merged 6 commits into from Aug 14, 2023
Merged

[NO SQUASH] async env / mapgen fixes #13703

merged 6 commits into from Aug 14, 2023

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Jul 30, 2023

some quick commits extracted from my other PR again

To do

This PR is Ready for Review.

@sfan5 sfan5 added @ Script API Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Bugfix 🐛 PRs that fix a bug labels Jul 30, 2023
builtin/async/game.lua Outdated Show resolved Hide resolved
@sfan5 sfan5 added the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Jul 31, 2023
@sfan5 sfan5 removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Aug 5, 2023
Copy link
Member

@rubenwardy rubenwardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@Desour Desour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine otherwise. 👍

builtin/async/game.lua Outdated Show resolved Hide resolved
src/mapgen/mapgen.cpp Outdated Show resolved Hide resolved
@sfan5 sfan5 merged commit 2c987b6 into minetest:master Aug 14, 2023
15 checks passed
@sfan5 sfan5 deleted the pre_mglua2 branch August 14, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements @ Script API >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants