New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO SQUASH] async env / mapgen fixes #13703
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
added
@ Script API
Maintenance
Tasks to keep the codebase and related parts in order, including architectural improvements
Bugfix 🐛
PRs that fix a bug
labels
Jul 30, 2023
sfan5
commented
Jul 30, 2023
sfan5
added
the
Action / change needed
Code still needs changes (PR) / more information requested (Issues)
label
Jul 31, 2023
sfan5
removed
the
Action / change needed
Code still needs changes (PR) / more information requested (Issues)
label
Aug 5, 2023
rubenwardy
approved these changes
Aug 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Desour
reviewed
Aug 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine otherwise. 👍
-55% runtime in singlenode usage, which is the best case
Desour
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bugfix 🐛
PRs that fix a bug
Maintenance
Tasks to keep the codebase and related parts in order, including architectural improvements
@ Script API
>= Two approvals ✅ ✅
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some quick commits extracted from my other PR again
To do
This PR is Ready for Review.