[NO SQUASH] Inventory: Fix assertion caused by a no-op stack movement #13717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
reviewed
Aug 14, 2023
The list of dragged stacks includes the source stack, which however does not need to be moved onto itself. This is an optimization.
SmallJoker
force-pushed
the
inv_nop_move_assert
branch
from
28ee491
to
39e9beb
Compare
SmallJoker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13716
Moving a stack onto itself caused the assertion to fail because it cannot be swapped with itself. Hence such operations are now all considered as no-ops.
To do
This PR is Ready for Review.
How to test