Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set item description as infotext for item entities #13728

Merged
merged 1 commit into from Aug 24, 2023

Conversation

fluxionary
Copy link
Contributor

  • Goal of the PR

this allows seeing what a dropped item is before you pick it up.

  • How does the PR work?

it adds the item's description to the infotext in the item's properties.

  • Does it resolve any reported issue?

i don't think so.

probably not.

  • If not a bug fix, why is this PR needed? What usecases does it solve?

this is just a minor quality-of-life tweak.

How to test

launch any world, drop an item, and point your reticle at it.

@wsor4035 wsor4035 added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Feature ✨ PRs that add or enhance a feature labels Aug 11, 2023
@sfan5 sfan5 changed the title show item description in infotext for item entities Set item description as infotext for item entities Aug 15, 2023
@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Aug 19, 2023

Does this work with multi-line item descriptions? If not, use get_short_description() instead.

@srifqi
Copy link
Member

srifqi commented Aug 19, 2023

Does this work with multi-line item descriptions?

This does work for multi-line descriptions (maximum 6 lines after text wrapping).

Screenshot of the PR

@fluxionary
Copy link
Contributor Author

get_short_description

is fundamentally broken: #12566

@srifqi srifqi merged commit 587e2b2 into minetest:master Aug 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature ✨ PRs that add or enhance a feature One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants