Revert some of the recent gui changes #13744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f7f3aaf. Fixes minetest#13743.
sfan5
added
the
Action / change needed
|
Yes, this sounds like there are two separate problems. These don't work: This works: I have no idea why. Maybe I made a mistake while testing... |
Desour
removed
the
Action / change needed
Desour
changed the title
|
Well, then let's revert them too. Sorry for the disturbance. |
grorp
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts that commit from #13732 to fix #13743.
Can't easily test, sorry. Someone else should implement the change properly.
To do
This PR is a Ready for Review.
How to test
Try #13743.