New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings GUI: Use language names rather than codes #13752
Settings GUI: Use language names rather than codes #13752
Conversation
Slightly related: To help with #9141, we could add diff --git a/builtin/mainmenu/settings/dlg_settings.lua b/builtin/mainmenu/settings/dlg_settings.lua
index b8d99a469..6049729a4 100644
--- a/builtin/mainmenu/settings/dlg_settings.lua
+++ b/builtin/mainmenu/settings/dlg_settings.lua
@@ -68,6 +68,8 @@ add_page({
id = "accessibility",
title = gettext("Accessibility"),
content = {
+ "language",
+ { heading = gettext("General") },
"font_size",
"chat_font_size",
"gui_scaling", It even makes sense: One could argue that localization is an accessibility feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(See comments on lines for the requests)
PS grorp's suggestion is good, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, code looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me. (If any) naming errors can be addressed later.
PS I really want to invite the Minetest translators for checking these local names, but that is highly unlikely and will just cause delays.
Part of #13476
Showing language codes isn't very user friendly. This PR makes it so the language dropdown shows the local name for the language.
This is also a prerequisite to making other drop downs translatable (for that, I'll need to update the settingtypes parser to create these labels and update translation templates. For a future PR).
To do
This PR is Ready for Review
How to test