Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use formspec version 6 in the main menu #13761

Merged
merged 6 commits into from Aug 28, 2023

Conversation

rubenwardy
Copy link
Member

@rubenwardy rubenwardy commented Aug 28, 2023

This makes all the tabs in the mainmenu use formspec version 6 and real coordinates. To do this, the local tab has been updated to work with real coordinates

This is a prerequisite to replacing the settings tab with a settings button, part of #13476

image

To do

This PR is Ready for Review

  • Make fields on the left longer, to take up available space minus a margin

How to test

  • Open main menu
  • Test that the Start Game tab works as expected

@rubenwardy rubenwardy added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements @ Mainmenu Formspec labels Aug 28, 2023
@rubenwardy rubenwardy added this to the 5.8.0 milestone Aug 28, 2023
@rubenwardy rubenwardy marked this pull request as ready for review August 28, 2023 15:34
Copy link
Member

@grorp grorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on my Android device with default Minetest scaling settings. Here is a screenshot:

screenshot new

The left side of the tab looks very crowded, although there is still free space at the bottom. The checkboxes even overlap each other: If you zoom in, you can see that they are wider than they are tall. I think more vertical spacing is needed.

This was slightly better with the old version of the tab:

screenshot old

In particular, the checkboxes did not overlap, but were nearly exactly aligned.

Looks good to me otherwise, but I can't look at the code right now. (The "Open Settings" button got even more ugly, but that doesn't matter for obvious reasons.)

@rubenwardy
Copy link
Member Author

I forgot to increase the spacing between the checkboxes to account for the move to real coords, done now

@rubenwardy rubenwardy requested a review from grorp August 28, 2023 20:56
@grorp
Copy link
Member

grorp commented Aug 28, 2023

What about this? grorp@4c6f28a

screenshot after proposed changes

It makes the left side use the full available vertical space again, i.e. the bottom of the last field is at 7.1 - 0.375.

@rubenwardy
Copy link
Member Author

Looks good, applied that

Copy link
Member

@grorp grorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from that.

builtin/fstk/buttonbar.lua Outdated Show resolved Hide resolved
Co-authored-by: Gregor Parzefall <82708541+grorp@users.noreply.github.com>
@rubenwardy rubenwardy merged commit 0cbf96c into minetest:master Aug 28, 2023
1 of 2 checks passed
@rubenwardy rubenwardy deleted the mainmenu_tabs_use_fsv6 branch August 28, 2023 21:36
@grorp grorp mentioned this pull request Aug 29, 2023
grorp added a commit to grorp/minetest that referenced this pull request Aug 29, 2023
kawogi pushed a commit to kawogi/minetest that referenced this pull request Dec 19, 2023
kawogi pushed a commit to kawogi/minetest that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Formspec @ Mainmenu Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants