[NoSquash] Replace settings tab with button #13762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenwardy
added
@ Startup / Config / Util
@ Mainmenu
Waiting (on dependency)
|
Graphically speaking is pretty bad, the icon was more subtle. Icon + text, if any |
|
This is still a draft PR - I was going to ask you for the icon again |
rubenwardy
force-pushed
the
remove_settings_tab
branch
2 times, most recently
from
983a677
to
11a526e
Compare
rubenwardy
added
WIP
|
I think an icon would be much better than a button, but the problem is that the art style wouldn't match the rest of the main menu. imo the tabs and other buttons should also be changed to have more of a pixel art style. possibly for a different PR. Also I think an icon is enough for the settings, since less text means less translations overflowing to the side. |
rubenwardy
force-pushed
the
remove_settings_tab
branch
from
11a526e
to
c5e751d
Compare
rubenwardy
changed the title
rubenwardy
removed
the
WIP
rubenwardy
force-pushed
the
remove_settings_tab
branch
from
c5e751d
to
d540289
Compare
|
Updated with icon provided by Zughy |
rubenwardy
force-pushed
the
remove_settings_tab
branch
from
d540289
to
9c9cec4
Compare
srifqi
requested changes
Aug 30, 2023
grorp
requested changes
Aug 30, 2023
grorp
added
the
Action / change needed
rubenwardy
removed
the
Action / change needed
rubenwardy
force-pushed
the
remove_settings_tab
branch
from
9c9cec4
to
14ad891
Compare
rubenwardy
force-pushed
the
remove_settings_tab
branch
2 times, most recently
from
a25f14b
to
0ab1b9d
Compare
srifqi
approved these changes
Sep 7, 2023
grorp
approved these changes
Sep 7, 2023
grorp
added
the
Action / change needed
rubenwardy
force-pushed
the
remove_settings_tab
branch
from
0ab1b9d
to
a635073
Compare
rubenwardy
force-pushed
the
remove_settings_tab
branch
from
a635073
to
0e002ee
Compare
srifqi
added
>= Two approvals ✅ ✅
and removed
Action / change needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13476
To do
This PR is Ready for Review
How to test