[NOSQUASH] Fix clang warnings #13767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desour
added
Maintenance
sfan5
reviewed
Aug 29, 2023
sfan5
approved these changes
Sep 8, 2023
grorp
approved these changes
Sep 9, 2023
srifqi
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang currently screams pretty loud with its warnings. They are fixed here.
See also: minetest/irrlicht#229
To do
This PR is a Ready for Review.
How to test
Build with
-DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang.(Tested with clang 16.)