Restore the appearance of the "Start Game" tab after #13761 #13769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenwardy
approved these changes
Aug 29, 2023
srifqi
approved these changes
Aug 30, 2023
|
Applied your suggestion. Also updated the PR to get even closer to the original version of the tab. Two screenshots: Before #13761 With this PR The differences should really be minimal now. |
grorp
changed the title
srifqi
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly restores the appearance of the "Start Game" tab to how it was before #13761. Since that PR was only meant to migrate the tab to real coordinates, I assume that these visual changes were not intended. (There are more visual changes from that PR, but I have no idea whether they are good or bad.)
Good,
masterbranch before #13761 (commit 7b56daa)Bad, current
masterbranch (commit 0cbf96c)Good, this PR (commit ef07d89)
To do
This PR is a Ready for Review.
How to test
Verify that the mainmenu looks closer to how it looked before #13761 again.