send ParticleSpawners to all players when time = 0 #13774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grorp
added
@ Network
Trivial
grorp
requested changes
Sep 2, 2023
There was a problem hiding this comment.
Tested, works. I have left a comment on the code.
Also, according to our Git Guidelines, commit messages must start with a capital letter:
Commit messages must start with a capital letter and must be in the present tense.
grorp
added
the
Action / change needed
|
|
chmodsayshello
force-pushed
the
pspawner_bugfix
branch
from
c54185d
to
ac11409
Compare
grorp
removed
the
Action / change needed
grorp
approved these changes
Sep 2, 2023
sfan5
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ParticleSpawners are not sent to all players when they are only short lived, which is implemented checking if time is under a hardcoded value (1). However, when time is euqal to 0, that condition is also true, even though it means that the spawner exists forever (lua api).
This PR fixes that bug by making sure time is not 0.
How to test