Higher default graphics quality on Android #13780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grorp
added
@ Startup / Config / Util
Android
Feature ✨
grorp
commented
Sep 4, 2023
grorp
commented
Sep 4, 2023
| settings->setDefault("sqlite_synchronous", "1"); | ||
| settings->setDefault("map_compression_level_disk", "-1"); | ||
| settings->setDefault("map_compression_level_net", "-1"); |
There was a problem hiding this comment.
map_compression_level_disk and map_compression_level_net were redundant here since their default values are the same on desktop.
|
The CI failure is a dependency installation error on macOS. |
srifqi
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly (really) increases the default graphics quality on Android:
smooth_lightingenabled by defaultenable_3d_cloudsenabled by defaultfps_max_unfocusedincreased to the same value as on desktop(On Android, there is a scrollbar in the pause menu, so a low
fps_max_unfocusedvalue is quite annoying.)This doesn't have any impact on the framerate on my Android device (relatively new, but relatively cheap phone model). These changes are good for the first impression Android users get of Minetest. More changes in this direction could be made (see #12010), but this is a start.
To do
This PR is a Ready for Review.
How to test
Enjoy the higher-by-default graphics quality on Android.