Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undocumented and useless air_equivalent parameter #13790

Closed
wants to merge 1 commit into from
Closed

Remove undocumented and useless air_equivalent parameter #13790

wants to merge 1 commit into from

Conversation

Zughy
Copy link
Member

@Zughy Zughy commented Sep 10, 2023 •
edited

Fixes #13722 . The parameter doesn't appear anywhere in the code, it doesn't do anything

To do

This PR is Ready for Review.

How to test

--

@Zughy Zughy added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines @ Builtin labels Sep 10, 2023
@erlehmann
Copy link
Contributor

I suggest to not merge this PR without figuring out which games and mods rely on this being truthy.

See #13722 (comment) for more info.

@erlehmann
Copy link
Contributor

DO NOT MERGE THIS!

See #13722 (comment) ff for findings revelant to this PR.

TL;DR:

  • This property is not useful for the engine anymore.
  • The property seems to be useful for mods.
  • No one found a clear replacement yet.

@Zughy Zughy closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srifqi srifqi srifqi approved these changes

@grorp grorp grorp approved these changes

Assignees
No one assigned
Labels
@ Builtin Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

air_equivalent is undocumented
4 participants
@Zughy @erlehmann @srifqi @grorp