Language blacklist does not exclude translations on Android

[rollerozxa]

Minetest version

5.8.0-dev (I believe the issue still exists and can be reproducible in Minetest master)

Active renderer

No response

Irrlicht device

No response

Operating system and version

Android

CPU model

No response

GPU model

No response

OpenGL version

No response

Summary

The language blacklist that is used on desktop to exclude translations for RTL languages that don't show up text does not apply to Android, as translations are generated and copied by Gradle rather than CMake.

Now that Android detects the system's locale as of recent, if the device has a RTL language it will select the language and load the translation for the broken RTL language, leading to all translated text showing up as empty on startup. The person who reported this bug to me attached the following screenshot:

Steps to reproduce

1. Set your system locale on Android to one that is RTL
2. Set minetest to the "(Use system language)" language option (the default)
3. No text!

[sfan5]

While Android uses cmake it does not use the install scripts, so translations are compiled by gradle:

minetest/android/app/build.gradle

Lines 88 to 95 in a88e61c

	// compile translations
	fileTree("${projRoot}/po").include("**/*.po").forEach { poFile ->
	def moPath = "${assetsFolder}/locale/${poFile.parentFile.name}/LC_MESSAGES/"
	file(moPath).mkdirs()
	exec {
	commandLine 'msgfmt', '-o', "${moPath}/minetest.mo", poFile
	}
	}

I don't know if it's easily possible to defer this to cmake.

[srifqi]

This is caused by Minetest not checking whether the system language (or the selected language) is in the language blocklist or not. Minetest just relies on CMake to not compile the translation.

Creating the same list in src/gettext.cpp might help. To make the APK smaller, we can also add the filter in android/app/build.gradle.

This issue happens in Windows (10.0.19045), too. I tested it by setting the system language into Hindi (hi).