Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. mainmenu fixes #13859

Merged
merged 4 commits into from Oct 1, 2023
Merged

Misc. mainmenu fixes #13859

merged 4 commits into from Oct 1, 2023

Conversation

grorp
Copy link
Member

@grorp grorp commented Sep 30, 2023

This PR makes some small fixes to the mainmenu. Read the commit messages for details.

To do

This PR is a Ready for Review.

How to test

a. Look at the mainmenu on desktop.
b. Look at the mainmenu on Android.

grorp and others added 4 commits September 30, 2023 12:54
(It doesn't work.)

Co-authored-by: ROllerozxa <rollerozxa@voxelmanip.se>
Allows using a higher gui_scaling value without the gamebar going off-screen.
@grorp grorp added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Bugfix 🐛 PRs that fix a bug @ Mainmenu and removed Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels Sep 30, 2023
@grorp grorp merged commit 94eba15 into minetest:master Oct 1, 2023
2 checks passed
Zughy pushed a commit to Zughy/minetest that referenced this pull request Oct 8, 2023
* settingstypes.txt: Fix wrong default value for profiler.report_path

* Disable Irrlicht file picker on Android
  (It doesn't work.)

* Join Game tab: Fix server description textarea being misaligned with background

* Reduce distance between tab and gamebar on Android
  Allows using a higher gui_scaling value without the gamebar going off-screen.

Co-authored-by: ROllerozxa <rollerozxa@voxelmanip.se>
@grorp grorp deleted the misc-mainmenu-fixes branch December 18, 2023 16:39
kawogi pushed a commit to kawogi/minetest that referenced this pull request Dec 19, 2023
* settingstypes.txt: Fix wrong default value for profiler.report_path

* Disable Irrlicht file picker on Android
  (It doesn't work.)

* Join Game tab: Fix server description textarea being misaligned with background

* Reduce distance between tab and gamebar on Android
  Allows using a higher gui_scaling value without the gamebar going off-screen.

Co-authored-by: ROllerozxa <rollerozxa@voxelmanip.se>
cosin15 pushed a commit to cosin15/minetest that referenced this pull request Feb 24, 2024
* settingstypes.txt: Fix wrong default value for profiler.report_path

* Disable Irrlicht file picker on Android
  (It doesn't work.)

* Join Game tab: Fix server description textarea being misaligned with background

* Reduce distance between tab and gamebar on Android
  Allows using a higher gui_scaling value without the gamebar going off-screen.

Co-authored-by: ROllerozxa <rollerozxa@voxelmanip.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants