Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Allow disabling documentation build + print more build flags #13871

Merged
merged 2 commits into from Oct 9, 2023

Conversation

nerzhul
Copy link
Member

@nerzhul nerzhul commented Oct 6, 2023

I currently had a doxygen setup issue on my side, for unknown reason anyway.

It triggers issue on my side like this

minetest-stock/cmake-build-release on  master [$!] via △ v3.27.7 took 50s 
❯ cmake .. -D RUN_IN_PLACE=1
-- *** Will build version 5.8.0-dev ***
-- Using user-provided IrrlichtMt at subdirectory 'lib/irrlichtmt'
-- *** Building IrrlichtMt 1.9.0.12 ***
-- Performing Test REVISION_SANITY_CHECK
-- Performing Test REVISION_SANITY_CHECK - Success
-- Device: X11
-- OpenGL: ON
-- OpenGL 3: FALSE
-- OpenGL ES: OFF
-- OpenGL ES 2: OFF
-- WebGL: OFF
-- Found IrrlichtMt 1.9.0.12
-- Using GMP provided by system.
-- Using bundled JsonCpp library.
-- LuaJIT detection disabled! (ENABLE_LUAJIT=0)
-- LuaJIT not found, using bundled Lua.
-- cURL support enabled.
-- GetText enabled; locales found: ar;be;bg;ca;cs;cy;da;de;dv;el;eo;es;et;eu;fi;fil;fr;gd;gl;he;hi;hu;id;it;ja;jbo;kk;kn;ko;ky;lt;lv;lzh;mn;mr;ms;ms_Arab;nb;nl;nn;oc;pl;pt;pt_BR;ro;ru;sk;sl;sr_Cyrl;sr_Latn;sv;sw;th;tr;tt;uk;vi;yue;zh_CN;zh_TW
-- Sound enabled.
-- ncurses console enabled.
-- PostgreSQL backend enabled
-- PostgreSQL includes: /usr/include;/usr/include/postgresql/server
-- LevelDB not found!
-- Redis backend enabled.
-- Prometheus client disabled.
-- SpatialIndex AreaStore backend enabled.
-- Looking for ZSTD_initCStream
-- Looking for ZSTD_initCStream - found
-- Locale blacklist applied; Locales used: be;bg;ca;cs;cy;da;de;el;eo;es;et;eu;fi;fil;fr;gd;gl;hu;id;it;ja;jbo;kk;ko;ky;lt;lv;lzh;mn;mr;ms;nb;nl;nn;oc;pl;pt;pt_BR;ro;ru;sk;sl;sr_Cyrl;sr_Latn;sv;sw;tr;tt;uk;vi;yue;zh_CN;zh_TW
-- Performing Test HAVE_ATCCALL
-- Performing Test HAVE_ATCCALL - Success
CMake Warning at /usr/share/cmake/Modules/FindDoxygen.cmake:497 (message):
  Unable to determine doxygen version: No such file or directory
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindDoxygen.cmake:660 (_Doxygen_find_doxygen)
  CMakeLists.txt:399 (find_package)


CMake Error at /usr/share/cmake/Modules/FindDoxygen.cmake:739 (message):
  Unable to generate Doxyfile template: No such file or directory
Call Stack (most recent call first):
  CMakeLists.txt:399 (find_package)

I added a cmake build flag (BUILD_DOCUMENTATION) to disable documentation build (default is enabled)

I also added output for some interesting flags, to remember what targets we wanted to build

❯ cmake .. -D RUN_IN_PLACE=TRUE -DBUILD_DOCUMENTATION=FALSE
-- *** Will build version 5.8.0-dev ***
-- Compiling client: TRUE
-- Compiling server: FALSE
-- Compiling unittests: TRUE
-- Compiling benchmarks: FALSE
-- Generating documentation: FALSE
-- Run in place build: TRUE
-- Using user-provided IrrlichtMt at subdirectory 'lib/irrlichtmt'
-- *** Building IrrlichtMt 1.9.0.12 ***

@nerzhul nerzhul added the @ Build CMake, build scripts, official builds, compiler and linker errors label Oct 6, 2023
@nerzhul nerzhul changed the title build: permit to disable documentation build build: permit to disable documentation build + add some interesting flags output Oct 6, 2023
@rubenwardy rubenwardy changed the title build: permit to disable documentation build + add some interesting flags output build: Allow disabling documentation build + print more build flags Oct 6, 2023
@nerzhul nerzhul requested a review from grorp October 7, 2023 20:58
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@grorp grorp added the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Oct 8, 2023
@rubenwardy rubenwardy removed their request for review October 8, 2023 15:31
@sfan5 sfan5 removed their request for review October 8, 2023 16:38
@nerzhul
Copy link
Member Author

nerzhul commented Oct 9, 2023

@grorp thanks for your review, fixes are now adressed

@sfan5 sfan5 removed the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Oct 9, 2023
@nerzhul nerzhul merged commit 929a13a into minetest:master Oct 9, 2023
12 checks passed
@nerzhul nerzhul deleted the feat/build_doc branch October 9, 2023 13:35
kawogi pushed a commit to kawogi/minetest that referenced this pull request Dec 19, 2023
…inetest#13871)

* build: permit to disable documentation build

* build: add a message about some BUILD_* flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Build CMake, build scripts, official builds, compiler and linker errors >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants