Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation mark on TGA texture format in lua_api.md #13877

Merged
merged 1 commit into from Oct 22, 2023

Conversation

corarona
Copy link
Contributor

@corarona corarona commented Oct 8, 2023

Add compact, short information about your PR for easier understanding:

TGA support is actively used in both mineclonia and mineclone2, it is also used by the tga_encoder, unicode_text and my recent unicode_signs mod which uses the former 2.

If anything .bmp should be removed and not tga, which would save a lot more code as well if I understand it right (which I maybe do not).

How to test

  • Read the lua_api.md in master and be shocked by the fact that TGA is marked as deprecated.
  • Read it again on this branch and rejoice in the fact that the deprecation mark was removed.

@sfan5
Copy link
Member

sfan5 commented Oct 9, 2023

FWIW the coredev opinion on this seems to be mostly neutral/positive (except me) so I don't know if "controversial" is warranted.

@erlehmann
Copy link
Contributor

erlehmann commented Oct 15, 2023

TGA was removed previously and then re-added. I do not see how the situation has changed since then.

If anything, more mods use TGA now than back then.

Btw, just in case anyone comes across this PR in the future and does not want to ponder it too much: The decision whether to deprecate TGA or not, beyond compatibility concerns, is pretty much “Does Minetest want to support an image format that is easy to write and read from Lua or not?” (i.e. can you roundtrip an image by decoding and encoding it or not).

Given the presence of minimum-effort PNG encoding capabilities and complete lack of image reading capabilities in the Minetest engine, I believe that the decision basically comes down to “Should Minetest mods be easily able to edit textures loaded from files (or item meta)?”. I think they should, so that e.g. handheld maps can be (sort of) live-updated, zoomed out and combined.

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

@celeron55
Copy link
Member

celeron55 commented Oct 15, 2023

At this point I will give my +1 to this.

The arguments against it are mostly about the potential maintenance burden, and the arguments for it are mostly about preference and ease of use. It's difficult to predict how much work maintenance will require, but it is a relatively simple format which could mean it's simple to maintain, and I am in general a proponent of simple easy to use things.

In general we should be happy MT has a feature someone likes this much.

@erlehmann
Copy link
Contributor

Please remember to merge this before the release to prevent confusion.

@SmallJoker SmallJoker merged commit 341e53f into minetest:master Oct 22, 2023
@corarona corarona deleted the undeprecate_tga branch October 23, 2023 21:23
kawogi pushed a commit to kawogi/minetest that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TGA deprecation and put it in a ”do not deprecate again” list
6 participants