Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the +/- numpad default behaviour (increase/decrease viewing range) #13890

Closed
Zughy opened this issue Oct 13, 2023 · 4 comments
Closed
Labels
@ Client / Controls / Input Feature request Issues that request the addition or enhancement of a feature Regression Something that used to work no longer does.
Milestone

Comments

@Zughy
Copy link
Member

Zughy commented Oct 13, 2023

Problem

It's not possible to use +/- on the numpad anymore to increase/decrease the viewing range, since some 5.8.0-dev commit

Solutions

Restore such behaviour

Alternatives

Issue forms are kinda annoying

Additional context

No response

@Zughy Zughy added Feature request Issues that request the addition or enhancement of a feature Regression Something that used to work no longer does. @ Client / Controls / Input labels Oct 13, 2023
@Zughy Zughy added this to the 5.8.0 milestone Oct 13, 2023
@grorp
Copy link
Member

grorp commented Oct 13, 2023

As stated on IRC, this is caused by #13773.

"Numpad Plus" and "Plus" are now considered two different keys, and "Increase Viewing Range" is still bound to "Plus" by default
I'm not sure what can be done about this problem. I don't think that PR should simply be reverted, it's useful to be able to bind e.g. "1" and "Numpad 1" to different actions.

rubenwardy's suggestion:

Should be bound to both keys by default then

https://irc.minetest.net/minetest-dev/2023-10-11#i_6121252

@erlehmann
Copy link
Contributor

@grorp say, is #13773 also causing #13899 maybe?

(If it does, my suggestion would be to revert that thing instead of binding more keys.)

@erlehmann
Copy link
Contributor

erlehmann commented Oct 29, 2023

I have confirmed that reverting the change from #13773 also fixes the regression where I can not input a + at all because it needs a modifier key on my layout: #13899 (comment)

I think commit d57c936 should be reverted due to causing multiple regressions.

The idea is simply not very good if it results in users of layouts where “+” needs a modifier key to not be able to use a “+” at all.

@grorp
Copy link
Member

grorp commented Oct 31, 2023

Fixed by #13942.

@grorp grorp closed this as completed Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Client / Controls / Input Feature request Issues that request the addition or enhancement of a feature Regression Something that used to work no longer does.
Projects
None yet
Development

No branches or pull requests

3 participants