Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Russian translation of builtin #13896

Merged
merged 4 commits into from Oct 22, 2023
Merged

Add Russian translation of builtin #13896

merged 4 commits into from Oct 22, 2023

Conversation

alek13
Copy link
Contributor

@alek13 alek13 commented Oct 17, 2023

Just builtin translations

This was referenced Oct 17, 2023
Closed
Closed
@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Oct 18, 2023 

$ mtt_check.py builtin/
Error (builtin/locale/__builtin.ru.tr:6): Missing placeholder(s) in translation: '@1'

srifqi
srifqi requested changes Oct 18, 2023
View reviewed changes
builtin/locale/__builtin.ru.tr Outdated Show resolved Hide resolved
builtin/locale/__builtin.ru.tr Outdated Show resolved Hide resolved
builtin/locale/__builtin.ru.tr Outdated Show resolved Hide resolved
builtin/locale/__builtin.ru.tr Outdated Show resolved Hide resolved
builtin/locale/__builtin.ru.tr Outdated Show resolved Hide resolved
builtin/locale/__builtin.ru.tr Show resolved Hide resolved
@srifqi srifqi added the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Oct 18, 2023
alek13 and others added 2 commits October 19, 2023 18:34
@alek13 @srifqi @zmv7
Apply ru translation suggestions from code review
00d89a3 
Co-authored-by: Muhammad Rifqi Priyo Susanto <muhammadrifqipriyosusanto@gmail.com>
Co-authored-by: Zemtzov7 <72821250+zmv7@users.noreply.github.com>
@alek13
Fix translations after review
c06e5b4
@alek13 alek13 requested review from zmv7 and srifqi October 19, 2023 15:51
srifqi
srifqi approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@srifqi srifqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation is complete and no syntax error is found. I will let the Russian-speaking community to discuss whether the translation looks good or not.

@srifqi srifqi added One approval ✅ ◻️ and removed Action / change needed Code still needs changes (PR) / more information requested (Issues) labels Oct 20, 2023
@srifqi srifqi changed the title Add russian builtin translation Add Russian translation of builtin Oct 20, 2023
zmv7
zmv7 reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@zmv7 zmv7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished second review

@alek13 @zmv7
Apply suggestions for translate <pos1> / <pos2> from code review
dd2b28f 
Co-authored-by: Zemtzov7 <72821250+zmv7@users.noreply.github.com>
@alek13 alek13 requested a review from zmv7 October 20, 2023 13:57
zmv7
zmv7 reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@zmv7 zmv7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

grorp
grorp approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@grorp grorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a technical perspective. I don't speak Russian though.

@SmallJoker SmallJoker merged commit 3491509 into minetest:master Oct 22, 2023
kawogi pushed a commit to kawogi/minetest that referenced this pull request Dec 19, 2023
@alek13 @zmv7 @kawogi
Add Russian translation of builtin (minetest#13896)
5a7331c 
Co-authored-by: Zemtzov7 <72821250+zmv7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmv7 zmv7 zmv7 left review comments

@srifqi srifqi srifqi approved these changes

@grorp grorp grorp approved these changes

Assignees
No one assigned
Labels
@ Builtin @ Translation >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@alek13 @Wuzzy2 @srifqi @zmv7 @grorp @sfan5 @SmallJoker