Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename translation script to something more obvious #13897

Closed
Zughy opened this issue Oct 20, 2023 · 5 comments · Fixed by #13952
Closed

Rename translation script to something more obvious #13897

Zughy opened this issue Oct 20, 2023 · 5 comments · Fixed by #13952
Labels
good first issue Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. @ Startup / Config / Util @ Translation UI/UX
Milestone

Comments

@Zughy
Copy link
Member

Zughy commented Oct 20, 2023

Right now the file name is mtt_update.py, where I suppose the 2nd "t" stands for translate. It took me a bit before finding it in the util folder, as I consider the title not obvious (and I was helped by the latest commits name next to the files). All the other files in the util folder are straightforward.

Suggestions:

  • mod_translations_update
  • translations_update
  • I don't know, but I'd avoid specifying the .tr format in case Minetest starts supporting new formats such as .po§

I also suggest doing that before 5.8, so to avoid linking problems

@Zughy Zughy added @ Startup / Config / Util Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. UI/UX good first issue labels Oct 20, 2023
@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Oct 22, 2023

Yeah, agreed. mtt stands for Minetest Translation Tools because I pulled it directly from my script collection of the same name. So this part is just a "historical" artifact. MTT also includes a checker script which has not been included officially so far.
https://codeberg.org/Wuzzy/Minetest_Translation_Tools

I'm not sure which name to choose. And please add this to the 5.8 milestone because it should def. be done before release.

@Zughy Zughy added this to the 5.8.0 milestone Oct 22, 2023
@srifqi
Copy link
Member

srifqi commented Nov 1, 2023

  • translation_updater.py
  • mod_translation_updater.py (signifying for mods)
  • tr_updater.py (tr as in .tr files)
  • mod_tr_updater.py
  • updatetr.py (like updatepo.sh)

@Zughy
Copy link
Member Author

Zughy commented Nov 1, 2023

I think mod_translation_updater.py instantly conveys what it does, +1 for me

@srifqi
Copy link
Member

srifqi commented Nov 2, 2023

So, the changes are

  • util/mtt_update.py -> util/mod_translation_updater.py
  • util/README_mtt_update.md -> util/README_mod_translation_updater.md

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Nov 7, 2023

Oh lol, I was about to do this myself today but someone was faster. :D

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. @ Startup / Config / Util @ Translation UI/UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants