Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate .bmp format #13922

Merged
merged 1 commit into from Oct 27, 2023
Merged

Deprecate .bmp format #13922

merged 1 commit into from Oct 27, 2023

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Oct 25, 2023

implements #13918
removal can happen 5.9.0 earliest

@sfan5 sfan5 added @ Client / Audiovisuals Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements labels Oct 25, 2023
@sfan5 sfan5 added this to the 5.8.0 milestone Oct 25, 2023
erlehmann
erlehmann reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@erlehmann erlehmann left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, but definitely more complex than I would have written it.

It might make sense to also put a warning in the decoder (to catch dynamic use).

There exists no test case. Is this easy to test?

src/server.cpp Show resolved Hide resolved
@sfan5 sfan5 merged commit 03ba937 into minetest:master Oct 27, 2023
13 checks passed
@sfan5 sfan5 deleted the dep_bmp branch October 27, 2023 09:05
@grorp grorp mentioned this pull request Oct 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlehmann erlehmann erlehmann left review comments

Assignees
No one assigned
Labels
@ Client / Audiovisuals Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfan5 @erlehmann @lhofhansl