Mainmenu: Avoid the header being displayed behind the formspec #13924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srifqi
approved these changes
Oct 27, 2023
|
Apparently the header was usually slightly behind the formspec on desktop as well, and this PR causes the header to move a few pixels when you open a dialog. I'll try to improve this. |
grorp
added
the
Action / change needed
|
By the way, this also works for non-Android version. I tested this PR on Windows:
|
grorp
changed the title
grorp
removed
Android
Action / change needed
|
The header moves back and forth less again on desktop since my latest commit. But if the header usually ends up (slightly) behind the formspec even on desktop, maybe we should consider adjusting the original header placement code instead of just correcting its output. Anyway, the approach taken by this PR is probably fine as a simple fix for the Android issue. |
cx384
pushed a commit
to cx384/minetest
that referenced
this pull request
Dec 9, 2023
…est#13924) This change keeps the current header placement code, but adds additional code to make sure the header doesn't end up behind the formspec.
kawogi
pushed a commit
to kawogi/minetest
that referenced
this pull request
Dec 19, 2023
…est#13924) This change keeps the current header placement code, but adds additional code to make sure the header doesn't end up behind the formspec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the mainmenu header image is usually displayed behind the mainmenu formspec on Android. This results in three problems:
This PR keeps the current header placement code, but adds additional code to make sure the header doesn't end up behind the formspec. I don't claim that it's beautiful now, but I think it's better than before.
Here's a before/after comparison on Android:
On desktop, it looks the same as before.
To do
This PR is a Ready for Review.
A future PR could move the mainmenu formspec down a bit, giving more space to the header.
How to test
Start Minetest on your Android device. Verify that the mainmenu header isn't displayed behind the mainmenu formspec.