Extract updateClouds method from updateFrame

[JosiahWI]

This is a code cleanup. Other than adding this-> to member variables in the extracted method, no changes were made to the extracted code.

To do

Ready for Review.

How to test

I compiled a Debug build and confirmed in devtest that the clouds move and have the same appearance they did before.

[JosiahWI]

An automated formatter would help with these things. :)

[srifqi]

When changing these lines/functions, it might be better to also improve the comments (in one go).

diff --git a/src/client/game.cpp b/src/client/game.cpp
index d6a5a5bb6..cc8891547 100644
--- a/src/client/game.cpp
+++ b/src/client/game.cpp
@@ -4198,7 +4198,7 @@ void Game::updateClouds(float dtime)
 	if (this->sky->getCloudsVisible()) {
 		this->clouds->setVisible(true);
 		this->clouds->step(dtime);
-		// this->camera->getPosition is not enough for 3rd person views
+		// this->camera->getPosition is not enough for third-person camera.
 		v3f camera_node_position = this->camera->getCameraNode()->getPosition();
 		v3s16 camera_offset      = this->camera->getOffset();
 		camera_node_position.X   = camera_node_position.X + camera_offset.X * BS;
@@ -4206,14 +4206,13 @@ void Game::updateClouds(float dtime)
 		camera_node_position.Z   = camera_node_position.Z + camera_offset.Z * BS;
 		this->clouds->update(camera_node_position, this->sky->getCloudColor());
 		if (this->clouds->isCameraInsideCloud() && this->m_cache_enable_fog) {
-			// if inside clouds, and fog enabled, use that as sky
-			// color(s)
+			// If camera is inside cloud and fog is enabled, use cloud's colors as sky colors.
 			video::SColor clouds_dark = this->clouds->getColor().getInterpolated(
 					video::SColor(255, 0, 0, 0), 0.9);
 			this->sky->overrideColors(clouds_dark, this->clouds->getColor());
 			this->sky->setInClouds(true);
 			this->runData.fog_range = std::fmin(this->runData.fog_range * 0.5f, 32.0f * BS);
-			// do not draw clouds after all
+			// Clouds are not drawn in this case.
 			this->clouds->setVisible(false);
 		}
 	} else {

---

I found no changes/regressions from this PR.