Sounds: Don't pause new sounds when paused #13940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for #13931.
Rationale:
AFAIK, sounds are usually not played while paused (apart from the pause menu sounds), because mods get no callbacks anyway.
So, to get a playSound command to the sound manager while it's paused, you'd probably need some kind of race condition where the game is paused while the server's sound is passed to the client. This should happen very seldom in singleplayer (note that pause is a singleplayer-only feature). And if it happens, it will likely be a short sound, because those are more common than long ones.
To do
This PR is a Ready for Review.
How to test
See #13931.