Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOSQUASH] Sounds: Fix some fade-related bugs #13941

Merged
merged 2 commits into from Oct 28, 2023

Conversation

Desour
Copy link
Member

@Desour Desour commented Oct 28, 2023

Fixes two bugs introduced in #13633:

  • First is a missing conversion from milliseconds to seconds.
  • Second is that the sound manager used to not be stepped while paused, and hence did not fade sounds while paused. But now the sound manager thread always steps. I forgot to handle this.

To do

This PR is a Ready for Review.

How to test

  • Place a jukebox in devtest, and play some long sound, e.g. music.
  • Set the fade step on the right to 0.1, and target gain to 0.
  • For first commit: Press fade. Notice how it is by far too fast in master.
  • For second commit: Press fade. Pause the game (via esc). Wait a moment. Unpause, and listen if the sound is still there.

@Desour Desour added this to the 5.8.0 milestone Oct 28, 2023
@Desour Desour merged commit b3988d9 into minetest:master Oct 28, 2023
13 checks passed
@Desour Desour deleted the sounds_fix_fade branch October 28, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants