Extract Game::drawScene from Game::updateFrame #13967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were big banner comments setting apart this section of code, so
it was not hard to see it should be its own method. Besides the extraction,
there are only two code changes:
- this-> was added to member accesses in the extracted method.
- The player object was retrieved again at the top of the extracted
method so it wouldn't have to be passed in.
grorp
requested changes
Dec 15, 2023
grorp
added
the
Action / change needed
Co-authored-by: grorp <82708541+grorp@users.noreply.github.com>
Co-authored-by: grorp <82708541+grorp@users.noreply.github.com>
Co-authored-by: grorp <82708541+grorp@users.noreply.github.com>
This keeps the timing related code out of drawScene.
grorp
approved these changes
Dec 15, 2023
grorp
added
One approval ✅ ◻️
and removed
Action / change needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were big banner comments setting apart this section of code, so it was not hard to see it should be its own method. Besides the extraction, there are only two code changes:
To do
Ready for Review.
How to test
There should not any logical change. I confirmed in-game that things like the wield tool, crosshairs, and HUD are still there.