Fix auto_install_spec being used as a table #13970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(It's a string since minetest#13906.)
grorp
added
Trivial
rubenwardy
approved these changes
Nov 8, 2023
cx384
pushed a commit
to cx384/minetest
that referenced
this pull request
Dec 9, 2023
(It's a string since minetest#13906.)
kawogi
pushed a commit
to kawogi/minetest
that referenced
this pull request
Dec 19, 2023
(It's a string since minetest#13906.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed that line in #13906, where I changed the type of
auto_install_specfrom table to string. This resulted in wrong error messages when a package to be auto-installed was not found.To do
This PR is a Ready for Review.
How to test
Pass an invalid auto-install specification to
create_store_dlg. Enjoy seeing a correct error message.