Get rid of hidden settings in settings_translation_file.cpp #13984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13945.
Currently, the
"Hide:"category prefix is only respected by the settings GUI. This PR adds proper support (including nesting) for this prefix to the settingtypes parser. "settings_translation_file.cpp" now excludes hidden settings, but "minetest.conf.example" still includes them.If that's desired, I can also include the changes to the generated files caused by my changes to the generator in this PR.
To do
This PR is a Ready for Review.
Ideally, this PR should be merged before the next translation update.
How to test
Verify that the settings GUI still contains no hidden settings, and that it still contains all non-hidden settings.
Run the generator by uncommenting the relevant line in
builtin/mainmenu/settings/init.lua. Verify that "minetest.conf.example" still contains hidden settings. Verify that "settings_translation_file.cpp" doesn't contain hidden settings anymore.