[no squash] Return texture filter settings to previous state #14016
Conversation
This partially reverts commit 72ef908. fixes minetest#14007
|
@Warr1024 please test |
|
Looks good to me. CLARIFICATION: I have tested it and confirmed that it fixes the problem for my machine/config. |
sfan5
added
the
Action / change needed
It was determined that this fixes scaling artifacts that can happen with bilinear, trilinear or anisotropic filtering alone. Since the previous commit did not bring back the relevant setting, we fix this shortcoming by just enabling it in all cases where it is known to help.
sfan5
removed
the
Action / change needed
sfan5
changed the title
There was a problem hiding this comment.
LGTM
If we're sure enough that it won't accidentally cause more issues (I don't see how myself), I can add it as a separate commit to the PR.
Things that could go wrong:
-
There is a yet undiscovered problem with
imageCleanTransparent, be it a conceptual or an implementation problem, and users can no longer disableimageCleanTransparent. -
(Someone complains that the "the comic-like outlines" are gone.)
There was a problem hiding this comment.
Code checked. width/height scaling looks correct. Too high texture_min_size values seem predestined for issues. Limiting that to a saner value (e.g. 1024) might make sense in the future.
LGTM, although similar to Desour (see linked issue) I somehow could not reproduce this issue.
EDIT: Clarified with Warr1024 that his "LGTM" response is based on a check in-game and not code review.
original commit for reference: 72ef908
texture_clean_transparentwas not returned since it's automatically enabled when neededand it's useless in other cases