Made sure var 'pos' was only assigned locally to function #14027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should use luacheck for our wireshark dissector, same as for any other lua code. |
Desour
added
Trivial
Desour
approved these changes
Nov 22, 2023
|
@Desour fwiw, trivial PRs require only one approval afaik. You could hit merge right away. |
|
I know, but I don't want to do this immediately after I was the one to add the trivial tag. |
cx384
pushed a commit
to cx384/minetest
that referenced
this pull request
Dec 9, 2023
kawogi
pushed a commit
to kawogi/minetest
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is assigning to a var named
posbut it was not declared as local, instead it was assigning to a global variable. Considering it's a really common name for a var, which messes with IDE linting, and that the fix is tiny, I think it's worth just making itlocal.To do
Ready for Review.
How to test
n/a