Server: avoid re-use of recent ParticleSpawner and Sound IDs #14045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the reliability when removing and re-adding handles quickly. Looping through the entire ID range avoids collisions caused by any race condition.
sfan5
reviewed
Nov 26, 2023
| u32 free_id = m_particle_spawners_id_last_used; | ||
| while (free_id == 0 || m_particle_spawners.find(free_id) != m_particle_spawners.end()) { | ||
| if (free_id == m_particle_spawners_id_last_used) | ||
| return 0; // full |
There was a problem hiding this comment.
is zero a valid id?
I suppose not, would be good to use std::optional<u32> for the return one day
There was a problem hiding this comment.
I currently do not see any indicator that 0 is a reserved ID - neither on client- nor server-side. However, it will at least be more consistent other the ID assignments like in ActiveObjectMgr where 0 is reserved.
|
I didn't find time to test this before, sorry. This introduced a bug: Sound ids are reused to early.
To fix, either revert, or init |
cx384
pushed a commit
to cx384/minetest
that referenced
this pull request
Dec 9, 2023
…t#14045) This improves the reliability when removing and re-adding handles quickly. Looping through the entire ID range avoids collisions caused by any race condition.
kawogi
pushed a commit
to kawogi/minetest
that referenced
this pull request
Dec 19, 2023
…t#14045) This improves the reliability when removing and re-adding handles quickly. Looping through the entire ID range avoids collisions caused by any race condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the reliability when removing and re-adding handles quickly. Looping through the entire ID range avoids collisions caused by any race condition.
Fixes #14044
To do
This PR is Ready for Review.
How to test