Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language setting description in settingtypes.txt #14048

Merged
merged 2 commits into from Jan 15, 2024

Conversation

AFCMS
Copy link
Contributor

@AFCMS AFCMS commented Nov 27, 2023

Fix #13932

To do

This PR is Ready for Review.

How to test

Read diff. Check the tooltip of the language setting ingame.

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Nov 28, 2023

To the maintainers: If this is merged before the 5.8.0 release, please remember to update the translation files and Weblate so translators can react accordingly. Thanks.

@srifqi
Copy link
Member

srifqi commented Nov 28, 2023

Since the text will be copied into minetest.conf.example when the strings are updated, is the phrase, "Set to (Use system language) ...," which is used in the setting dialog, fine for minetest.conf?

builtin/settingtypes.txt Outdated Show resolved Hide resolved
@grorp grorp added the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Dec 12, 2023
@grorp grorp added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines and removed Action / change needed Code still needs changes (PR) / more information requested (Issues) labels Jan 15, 2024
@grorp grorp merged commit 9cca12f into minetest:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug @ Documentation @ Mainmenu One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip of language setting is somewhat wrong
5 participants