Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take aliases into account for automatic package installation #14052

Merged
merged 1 commit into from Nov 28, 2023
Merged

Take aliases into account for automatic package installation #14052

merged 1 commit into from Nov 28, 2023

Conversation

grorp
Copy link
Member

@grorp grorp commented Nov 28, 2023

Fixes #14050.

To do

This PR is a Ready for Review.

How to test

From #14050:

  1. Download an old copy of driftgame from the 2020-09-15 release available on ContentDB.
  2. Extract that copy of driftgame into your game directory.
  3. Since ContentDB manual downloads don't include a release number in the game.conf, add this line manually to the game.conf of driftgame: release = 6455.
  4. Launch Minetest, go to the Content tab, notice driftgame has an update, and press the Update button on that tab.
  5. You should get the same error as given in the summary. You should get no error.

@grorp grorp added this to the 5.8.0 milestone Nov 28, 2023
@grorp grorp merged commit cfe1953 into minetest:master Nov 28, 2023
2 checks passed
cx384 pushed a commit to cx384/minetest that referenced this pull request Dec 9, 2023
@grorp @cx384
Take aliases into account for automatic package installation (minetes…
e181bd4 
…t#14052)
@grorp grorp deleted the auto-install-pkg-aliases branch December 18, 2023 16:40
kawogi pushed a commit to kawogi/minetest that referenced this pull request Dec 19, 2023
@grorp @kawogi
Take aliases into account for automatic package installation (minetes…
bc31323 
…t#14052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenwardy rubenwardy rubenwardy approved these changes

@srifqi srifqi srifqi approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug @ Content / PkgMgr @ Mainmenu >= Two approvals ✅ ✅
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

Can't update a package that has been renamed on ContentDB from the Content Tab of Main Menu
3 participants
@grorp @rubenwardy @srifqi