Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't copy user texture packs into Android bundle #14053

Merged
merged 1 commit into from Nov 28, 2023

Conversation

grorp
Copy link
Member

@grorp grorp commented Nov 28, 2023

Currently, any texture packs you've downloaded will be included in the Android data bundle. This is annoying because it can make extracting take very long.

With this PR, only Minetest's built-in textures are included in the data bundle.

To do

This PR is a Ready for Review.

How to test

Download some texture packs and compile Minetest for Android. Verify that the texture packs aren't included in the Android build.

Also verify that all necessary textures are still included.

@grorp grorp added @ Build CMake, build scripts, official builds, compiler and linker errors Android Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Bugfix 🐛 PRs that fix a bug labels Nov 28, 2023
Copy link
Member

@srifqi srifqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

@grorp grorp merged commit dc6452d into minetest:master Nov 28, 2023
1 check passed
cx384 pushed a commit to cx384/minetest that referenced this pull request Dec 9, 2023
@grorp grorp deleted the android-dont-bundle-txps branch December 18, 2023 16:40
kawogi pushed a commit to kawogi/minetest that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Bugfix 🐛 PRs that fix a bug @ Build CMake, build scripts, official builds, compiler and linker errors Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines >= Two approvals ✅ ✅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants